On Wed, Apr 11, 2012 at 7:14 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Luke Diamand <luke@xxxxxxxxxxx> writes: > >> If P4EDITOR is defined, the tests will fail when "git p4" starts an >> editor. > > Is that a problem specific to tests, or should "git p4" itself unset that > environment? If it is a problem specific to tests, would it be a better > fix to add "P4EDITOR=:" like we do for EDITOR in t/test-lib.sh? Yes and no - git-p4.py will run $P4EDITOR if it is set, even if it's just empty. So it would need a small fix to check for an empty string. I can submit a suitable patch. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html