From: David Barr <david.barr@xxxxxxxxxxxx>
Date: Thu, 31 Mar 2011 22:59:57 +1100
Use a struct hash_table to allow the table for atom strings to
grow. See the previous commit for explanations.
[jn: with init_hash call, even though it's technically not needed]
Signed-off-by: David Barr <david.barr@xxxxxxxxxxxx>
Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
---
fast-import.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/fast-import.c b/fast-import.c
index a79a1260..67769573 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -299,9 +299,8 @@ static size_t total_allocd;
static struct mem_pool *mem_pool;
/* Atom management */
-static unsigned int atom_table_sz = 4451;
static unsigned int atom_cnt;
-static struct atom_str **atom_table;
+static struct hash_table atom_table;
/* The .pack file being generated */
static unsigned int pack_id;
@@ -691,10 +690,11 @@ static struct object_entry *find_mark(uintmax_t idnum)
static struct atom_str *to_atom(const char *s, unsigned short len)
{
- unsigned int hc = hc_str(s, len) % atom_table_sz;
+ unsigned int hc = hc_str(s, len);
struct atom_str *c;
+ void **pos;
- for (c = atom_table[hc]; c; c = c->next_atom)
+ for (c = lookup_hash(hc, &atom_table); c; c = c->next_atom)
if (c->str_len == len && !strncmp(s, c->str_dat, len))
return c;
@@ -702,8 +702,12 @@ static struct atom_str *to_atom(const char *s, unsigned short len)
c->str_len = len;
strncpy(c->str_dat, s, len);
c->str_dat[len] = 0;
- c->next_atom = atom_table[hc];
- atom_table[hc] = c;
+ c->next_atom = NULL;
+ pos = insert_hash(hc, c, &atom_table);
+ if (pos) {
+ c->next_atom = *pos;
+ *pos = c;
+ }
atom_cnt++;
return c;
}
@@ -3270,7 +3274,7 @@ int main(int argc, const char **argv)
alloc_objects(object_entry_alloc);
strbuf_init(&command_buf, 0);
- atom_table = xcalloc(atom_table_sz, sizeof(struct atom_str*));
+ init_hash(&atom_table);
branch_table = xcalloc(branch_table_sz, sizeof(struct branch*));
avail_tree_table = xcalloc(avail_tree_table_sz, sizeof(struct avail_tree_content*));
init_hash(&object_table);
--
1.7.10
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html