Felipe Contreras wrote:
> So we should never make any cleanups because some custom completion
> functions might theoretically break?
No, tasteful cleanups that don't break custom completion functions are
very welcome.
Also if you have evidence that this is definitely (not just possibly)
only a theoretical problem, then it would not be a regression. But I
actually find it likely that custom completion code would have
imitated the old completion code in git that used the suffix argument,
so...
Can you remind me what the benefit that the user is getting from this
patch in exchange for us breaking their tab completion? The title
("simplify __gitcomp") tells me exactly nothing about its impact
except that it is perhaps supposed to result in no behavior change.
Sorry for the fuss and hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html