Re: [RFC/PATCH] tests: add initial bash completion tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 07, 2012 at 02:12:22AM +0300, Felipe Contreras wrote:

> On Fri, Apr 6, 2012 at 11:19 PM, Jeff King <peff@xxxxxxxx> wrote:
> 
> > I think you need to start with something like:
> >
> >  #!/bin/sh
> >
> >  if ! type bash; then
> >          echo '1..0 # SKIP skipping bash tests, bash not available'
> >          exit 0
> >  fi
> 
> What about this instead?
> 
> ---
> #!/bin/sh
> 
> if type bash >/dev/null 2>&1
> then
> 	# execute inside bash
> 	[ -z "$BASH" ] && exec bash $0
> else
> 	echo '1..0 #SKIP skipping bash completion tests; bash not available'
> 	exit 0
> fi
> ---

Yes, that's fine. It should be functionally equivalent to what I posted,
but without having to invoke an extra bash when we are already running
it (and avoiding the giant here-doc, though that is simply ugly and not
a functional problem).

One minor fix. I think it should be:

  exec bash $0 "$@"

to pass arguments (e.g., "-v -i") to the bash sub-process.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]