On Fri, Apr 6, 2012 at 11:24 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Jeff King <peff@xxxxxxxx> writes: > >> On Fri, Apr 06, 2012 at 10:28:39PM +0300, Felipe Contreras wrote: >> >>> Something is better than nothing. >> >> Yes, but... > > ;-) > > This is a good example that sometimes something is worse than nothing, > unless watched carefully by a competent reviewer. And this is a good example of why you shouldn't blindly trust what a 'competent reviewer' says, as I'm pretty sure the comment is wrong. But hey, if you prefer nothing, fine, drop this patch; let's continue to blindly modify the completion and fix regressions as they come. I guess I should drop my other tests as well. I was planning to do a bit of reorganization to the bash completion after having some basic tests, but I'll just jump straight away to the actual patches then. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html