On Thu, Apr 05, 2012 at 11:55:18PM -0700, Junio C Hamano wrote: > I agree that submitters would benefit from an automated way to propagate > these addresses from reroll to reroll, and in a larger workflow "tweak and > record while amending a commit for reroll" would be a natural place to do > so, so I can see why it is tempting to abuse Cc: in the body of the > message, but not knowing other ways is not a good excuse for such an > abuse. A workable solution is already available [*1*]: commit with a > "---" line followed by Cc: and whatever extra junk while amending. I've played with that workflow before. While it's a neat trick, note that something like "format-patch -s" will put the signoff at the end, like: commit subject commit body --- Cc: whomever Signed-off-by: you which is not what you want. We could perhaps teach it to be smarter about finding a "---", though I worry about hurting people who do not use an email-based workflow, since they otherwise don't have to care about "---". About a year ago I had an RFC series to let "git commit" parse off the "---" bit and turn it into a git-note (mostly for keeping track of changes to the series between versions). It does solve that problem, and response was reasonably positive. It does make things more complicated, though, because IIRC you have to turn on note-rewriting manually to keep the notes attached as you rebase. Ultimately I didn't follow up because I've found that I just don't end up keeping a lot of notes. I tend to do the re-roll and then send it out pretty soon afterward, so I just write any notes in the emails as they go out. For complex "cc" lists and the like, I have a (fairly hacky) script that takes an existing message as input and generates a format-patch series with the to, cc, and in-reply-to fields filled in (and then I ship the result out via my regular MUA after proof-reading and tweaking). Potentially git-send-email could do the same thing. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html