On Thu, Apr 05, 2012 at 07:24:29PM -0400, Neil Horman wrote: > On Thu, Apr 05, 2012 at 01:12:51PM -0700, Junio C Hamano wrote: > > Neil Horman <nhorman@xxxxxxxxxxxxx> writes: > > > > > As a convienience, it would be nice if we could pop entries off the argv_array > > > structs so that if they had multiple uses in a function, we wouldn't have to > > > clear them and repopulate common entries. This patch adds the argv_array_pop > > > function to do just that. Common entries can be added to an argv_array first, > > > then useage specific ones can be added on the end and removed later on. > > > > > > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx> > > > > > > > CC: Jeff King <peff@xxxxxxxx> > > > CC: Phil Hord <phil.hord@xxxxxxxxx> > > > CC: Junio C Hamano <gitster@xxxxxxxxx> > > > --- > > > > Please don't do "Cc:" here; they belong to your e-mail header. > > > You mean place them below the snip line? I can do that. > Actually, I can't do that, git-send-email looks for CC: in the patch text, and git-format-patch automatically inserts the snip line. I can put the cc's on the command line, but if git-send-email is parsing this out of the wrong place, that seems like a bug. FWIW, CC's in this location are standard practice for kernel patch submissions. Neil -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html