Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Pete Wyckoff wrote: > >> This addresses all of Jonathan's comments, in particular: > > Nice. Thanks much. I only have a few small worries left: > > [...] >> +++ b/t/t9300-fast-import.sh >> @@ -2635,4 +2635,280 @@ test_expect_success \ > [...] >> +test_expect_success 'S: filemodify with garbage after sha1 must fail' ' >> + sha1=$(grep -w :103 marks | cut -d\ -f2) && > > "grep -w" isn't used elsewhere in the testsuite. Is it portable? It is not portable enough. > If I understood the discussion before correctly, this error message is > suboptimal and something like "invalid dataref" would be a little > clearer, right? > > That's orthogonal to what this patch is about so I'm not suggesting > changing it. But shouldn't the test just check that fast-import fails > without committing to any particular message? That would certainly make more sense. Thanks for being extra careful. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html