On Mon, Apr 02, 2012 at 05:13:48PM +0200, Ivan Todoroski wrote: > + else { > + /* read from stdin one ref per line, until EOF */ > + struct strbuf line; > + strbuf_init(&line, 0); A minor style nit, but we usually spell this: struct strbuf line = STRBUF_INIT; Other than that, this version looks good to me. Thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html