On Thu, 29 Mar 2012, W. Trevor King wrote:
> The git_feed() method was not setting a `Status` header unless it was
> responding to an If-Modified-Since request with `304 Not Modified`.
> Now, when it is serving successful responses, it sets status to
> `200 OK`.
Nice. This change is IMHO worth applying even without the rest of series.
So
Acked-by: Jakub Narebski <jnareb@xxxxxxxxx>
You _might_ also add that this change would allow robust testing of
If-Modified-Since request handling in gitweb, but it is not really
necessary.
>
> Signed-off-by: W Trevor King <wking@xxxxxxxxxx>
> ---
> gitweb/gitweb.perl | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index a8b5fad..041da17 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -7841,11 +7841,13 @@ sub git_feed {
> print $cgi->header(
> -type => $content_type,
> -charset => 'utf-8',
> - -last_modified => $latest_date{'rfc2822'});
> + -last_modified => $latest_date{'rfc2822'},
> + -status => '200 OK');
> } else {
> print $cgi->header(
> -type => $content_type,
> - -charset => 'utf-8');
> + -charset => 'utf-8',
> + -status => '200 OK');
> }
>
> # Optimization: skip generating the body if client asks only
> --
> 1.7.3.4
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html