On Wed, Mar 28, 2012 at 2:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Tim Henigan <tim.henigan@xxxxxxxxx> writes:
>
> OK, but doesn't File::Find recurse into its subdirectories? If you create
> a 'foo' directory there and drop a 'bar' script in it, is the rest of the
> code prepared to give you "git difftool -t foo/bar"?
It does recurse, but in this context '$_' only contains the current
file name within the directory...not the directory itself [1]. So if
we call 'find' on a directory that contains:
foo
bar/
baz
then @tools = ('foo', 'baz')
[1]: http://perldoc.perl.org/File/Find.html#The-wanted-function
>> + for (@tools) {
>> + my $tool = $_;
>> + next if ($tool eq "defaults");
>
> Now you use File::Find::find(), you probably should do this kind of
> trivial filtering inside the callback, no?
I thought about that, but the filter is so simple that it seemed like
overkill to add another function. If there is another revision of
this patch, I will reconsider.
As always, thanks for the review :)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html