Re: [PATCH v3] push: Provide situational hints for non-fast-forward errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 26, 2012 at 03:51:50PM -0400, Jeff King wrote:
> On Mon, Mar 26, 2012 at 03:20:01PM -0400, Christopher Tiwald wrote:
> 
> > I used the REF_STATUS_* enum as a template for what I wanted to accomplish
> > when authoring v1, but did notice there was no other place my new
> > options made much sense (Junio helped me remove one other call between v1
> > and v2). I like the readability fixup, but it won't compile as both push.c
> > and transport.c need to see these. Would something like the following
> > work? It simply moves the define statements to cache.h, so that both push and
> > transport can use them.
> 
> My suggestion put them in transport.h, which is included from both
> places. It compiles fine for me. Am I missing something?

Ah nope. That was me. Sorry about the noise. This otherwise makes sense
to me.

--
Christopher Tiwald
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]