Re: [PATCH] Documentation: improve description of GIT_EDITOR and preference order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rodrigo Silva "(MestreLion)"  <linux@xxxxxxxxxxxxxxxx> writes:

> So, what should I do now? Re-send the patch with just the accepted parts
> (and adjusting commit message accordingly)? Or this will be done by you?

People either say "Yeah, I agree with the suggestions---can you apply it
without the change to git-var.txt?", or respond to the review message with
an updated patch with "I agree with the review suggestion and dropped the
change to git-var.txt" after the three-dash lines (i.e. the comment does
not become part of the commit log message).

For something small and easy like this one, it's OK to do either way.

For larger changes, people tend to do the latter, as often they do not
agree (and they do not have to) with *all* the point raised in the review,
and it would become more error prone to let me pick, choose and edit the
original submission.

I'll just apply your patch with minor tweaks.  Thanks.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]