On Wed, Mar 21, 2012 at 01:09:24PM -0700, Junio C Hamano wrote: > In a more elaborate series, you would first add a lot of tests to nail the > behaviour of the existing code down, then refactor or reimplement them in > a different way, add tests that expect failure until the next phase, and > then add features and turn expect_failure in tests to expect_success. > > But I do not htink this single patch deserves that complexity. Does it > even have to split into three? Sorry, testing makes me think of test-driven development ;). Two patches it is (refactor + git_feed tests, git_snapshot + git_snapshot tests). -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
Attachment:
signature.asc
Description: OpenPGP digital signature