Jeff King wrote: > On Wed, Mar 21, 2012 at 07:28:24AM -0700, Shawn O. Pearce wrote: > > > > Would it be OK for fetch-pack.c to use the packetized format (pkt-line.h) > > > for reading the list of refs from stdin? > > > > This is probably the easiest way to implement the sneak-into-stdin > > patch. Use a pkt-line for each argument that should have been in the > > argv array from the command line, and a flush pkt to terminate the > > list. > > Something in me feels slightly uncomfortable with that, just because > simple newline-delimited formats make it easy for people to hack on the > tool and feed input from unexpected sources. Well, give people "pkt-line" command line tool which would transform ordinary textual output on input into pkt-line (which is almost pure text anyway) output and vice versa. > But stateless-rpc is already a pretty deep internal interface anyway, > and the format is already weird (the second half is already packetized > input from a remote anyway). So it's probably not worth caring about > hackability here. Right. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html