Junio C Hamano wrote:
Andy Parkins <andyparkins@xxxxxxxxx> writes:
* git-add has no output, whether it works or not
"git add no-such-file" complains, and I think that is adequate.
Now with Nico's 'add means adding contents, not path' change is
in, we _might_ want to differentiate adding a path that was
untracked before and updating the contents, but I think this
again falls into "doing exactly as told" category.
Well, it should really let the user know if it fails. I for one would
like to know that. I wasn't aware of the fact that it was silent even in
those situations (perhaps because I've never run across it).
The errors that need to be reported are, afaics:
Content in 'path/to/file' is ignored according to path/to/.gitignore.
System error X happened while attempting Y.
Hash collisions.
Hash collisions wouldn't be too bad to check for in git add, because it
only has to compare a single object, although I agree that it probably
isn't necessary.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html