Re: [PATCH] rebase -i: inform the user they can re-order commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:

> Nelson Benitez Leon <nelsonjesus.benitez@xxxxxxxxxxxxxx> writes:
>
>> +# You can re-order the commit lines to affect the order on which
>> +# the commits will be applied.
>
> That's probably the main use of "rebase -i", so it deserves a mention,
> yes.

Erm, read in isolation by people like you who _know_ what the command
does, the addition might look sensible, but I find that line of thinking
somewhat disturbing in the first place.

These are meant to be a short _reminder_ for people who _learned_ how the
command they already _know_ is spelled.

If the user does not even know that one of the primary use of the command
is to reorder, isn't he playing with fire?

If we come up with a politely worded message that makes the user realize
that the user does not know what he is doing and gently nudges the user to
read the documentation before continuing to potentially harm himself, that
would be a good addition, but...

So, I dunno.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]