Re: [PATCH v2 1/2] t0303: immediately bail out w/o GIT_TEST_CREDENTIAL_HELPER

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/15/2012 07:55 AM, Junio C Hamano wrote:
Jeff King<peff@xxxxxxxx>  writes:

On Wed, Mar 14, 2012 at 03:17:28PM -0700, Junio C Hamano wrote:
This is probably not related to your patch, but

	GIT_TEST_CREDENTIAL_HELPER=cache sh t0303-*.sh

passes OK for me while

	make GIT_TEST_CREDENTIAL_HELPER=cache T=t0303-*.sh prove

seems to get stuck forever.

It's because t0303 is the generic "test any helper" script, and does not
know how to clean up the credential-cache daemon. So the daemon sticks
around, holding onto a file descriptor that causes prove to hang.

And the reason why "sh t0303-*.sh" version does not have this problem is...?

It does :)

In both cases git-credential-cache--daemon is running. It is stuck in poll() with a timeout of 30*1000 ms (credentail-cache--daemon.c:175). When running without prove, it is left in the background and terminates after 30 s. When running under prove, prove waits for 30 seconds for the process to end and then terminates.

I think that this delay is OK, as it happens only when running an explicitly requested test, and only under prove.

Zbyszek
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]