Re: [PATCH 1/3] help: Fix help message for aliases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

2012-03-15 2:23 PM, Junio C Hamano wrote:
Namhyung Kim <namhyung.kim@xxxxxxx> writes:

-		printf("`git %s' is aliased to `%s'\n", argv[0], alias);
+		printf("`git %s' is aliased to `git %s'\n", argv[0], alias);

NAK.

What would the above change will do to one of my favorite alias?

$ git help who
`git who' is aliased to `!sh -c 'git log -1 --format="%an<%ae>" --author="$1"' -'

Wouldn't removing "git " from the first phrase be a better solution?


Right. But as I replied to Jeff King, it can be improved to check whether the aliased output is such a complicated commands or not. Now I see that we can examine if the first letter is '!'.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]