On Wed, Mar 14, 2012 at 03:18:23PM +0100, Zbigniew Jędrzejewski-Szmek wrote: > -pre_test() { > - test -z "$GIT_TEST_CREDENTIAL_HELPER_SETUP" || > - eval "$GIT_TEST_CREDENTIAL_HELPER_SETUP" > [...] > +$GIT_TEST_CREDENTIAL_HELPER_SETUP Except for losing the eval here that Junio mentioned, I think both patches look good. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html