Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: > Quite a chunk of builtin_diff_cmd deals with word-diff setup, defaults > and such. This makes the function a bit hard to read, but is also > asymmetric because the corresponding teardown lives in free_diff_words_data > already. Yay! "A bit hard to read" is a gross understatement ;-) Whether the series fixes a bug of not, this alone makes the patch worthwhile to look. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html