Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:
> 2012/3/14 Junio C Hamano <gitster@xxxxxxxxx>:
>> Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:
>>
>>> +#define COL_ENABLE(c) ((c) & COL_ENABLE_MASK)
>>
>> That is a misleading name for a boolean macro. It looked as if this
>>
>>> + assert(COL_ENABLE(colopts) != COL_AUTO);
>>
>> was asking the helper to *enable* the column machinery with the given set
>> of option in colopts, and expecting the helper to answer how it enabled
>> ("I took the 'automatic' decision path"). But that is not what is
>> happening.
> ...
> I'm running out of names. Suggestions are welcome.
An obvious interface to expose to API users (as opposed to internal
details to the implementation) would be "extern bool COL_ENABLED(opts);",
no?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html