Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
> (resetting cc list)
> Thomas Rast wrote:
>
>> Hmm, I had an alternate patch ready in the morning, but Junio beat us to
>> it and applied the old one to master.
>>
>> I don't really think it matters enough to apply *another*, so I'll leave
>> it at that.
>
> May I have a copy? If it makes the wording better somehow, I would be
> happy to do the work of making a patch on top of master using it.
Sure, but it's nothing magic :-)
------ 8< ------
Subject: [PATCH] git-am: error out when seeing -b/--binary
The --binary option to git-apply has been a no-op since 2b6eef9 (Make
apply --binary a no-op., 2006-09-06) and was deprecated in cb3a160
(git-am: ignore --binary option, 2008-08-09).
We could remove it outright, but let's be nice to people who still
have scripts saying 'git am -b' (if they exist) and tell them the
reason for the sudden failure.
Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx>
---
git-am.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/git-am.sh b/git-am.sh
index 0bd290b..e1bdbfc 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -379,8 +379,12 @@ do
case "$1" in
-i|--interactive)
interactive=t ;;
- -b|--binary)
+ --binary)
: ;;
+ -b)
+ gettextln >&2 "The -b option (shorthand for --binary, both no-ops) was removed in 1.7.10."
+ die "$(gettext "Please adjust your scripts.")"
+ ;;
-3|--3way)
threeway=t ;;
-s|--signoff)
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html