Re: [PATCH] xdiff: load full words in the inner loop of xdl_hash_record

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:
>
>> Also definitely post-v1.7.10 material, but I figure many people will
>> be interested.  Since it's such a central part of much of git, it's
>> also quite important that it gets tested heavily.
>
> I am interested but this is a material not beyond 'pu'.  Until it
> learns to be nice on platforms that do not like unaligned accesses
> or use big endian, that is.

Umm, nice how?  It leaves in the old version for those platforms.  I can
perhaps make it #error if we are unhappy about the user's platform, but
that's about it.  Testing for endianness is possible, but testing for
unaligned access risks SIGBUS and thus requires spawning a helper
program.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]