So far the automatic compilation in 'run' just ran rev-parse on the user input. This means the user could test once for v1.7.9 and once for 828ea97 (Git 1.7.9, 2012-01-27) and the script would never realize that they are actually the same. Even more confusingly, the user could test 828ea97d and ask about './aggregate.perl v1.7.9' and it would not find any results. Dereference to a commit when constructing the directory name to avoid this. Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx> --- t/perf/aggregate.perl | 2 +- t/perf/run | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/perf/aggregate.perl b/t/perf/aggregate.perl index 9c781fa..4586840 100755 --- a/t/perf/aggregate.perl +++ b/t/perf/aggregate.perl @@ -52,7 +52,7 @@ sub format_times { my $dir; last if -f $arg or $arg eq "--"; if (! -d $arg) { - my $rev = Git::command_oneline(qw(rev-parse --verify), $arg); + my $rev = Git::command_oneline(qw(rev-parse --verify), $arg."^{commit}"); $dir = "build/".$rev; } else { $arg =~ s{/*$}{}; diff --git a/t/perf/run b/t/perf/run index 886290b..e4f9c22 100755 --- a/t/perf/run +++ b/t/perf/run @@ -45,7 +45,7 @@ run_dirs_helper () { shift fi if [ ! -d "$mydir" ]; then - rev=$(git rev-parse --verify "$mydir" 2>/dev/null) || + rev=$(git rev-parse --verify "$mydir^{commit}" 2>/dev/null) || die "'$mydir' is neither a directory nor a valid revision" if [ ! -d build/$rev ]; then unpack_git_rev $rev -- 1.7.10.rc0.230.g16d90 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html