Junio C Hamano <gitster@xxxxxxxxx> writes: > Martin Stenberg <martin@xxxxxxxxxxx> writes: > >> From c88f00e06cb877f9d944fdec480f53a7a42dd990 Mon Sep 17 00:00:00 2001 >> From: Martin Stenberg <martin@xxxxxxxxxxx> >> Date: Fri, 9 Mar 2012 22:57:54 +0100 >> Subject: [PATCH] fix incorrect line number report for bad gitconfig > > Please drop these four lines. The commit object name is no use to > me, and the other lines duplicate what you have in the mail header. > ... > Please have a paragraph break before your S-o-b: line. > > Thanks. Review of the patch text follows. > ... Also could you add a couple of tests (you identified two cases in your log message) to make sure this fix will not be broken in the future, perhaps to t1300? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html