Junio C Hamano <gitster@xxxxxxxxx> writes: > Matthieu Moy <Matthieu.Moy@xxxxxxx> writes: > >> This patch prepares a transition to 'upstream', unlike the previous >> version which was advertizing 'current'. In most case, this would be >> the same, but 'upstream' is probably more sensible in case it points >> to a branch other than 'current'. I don't care much either way. > > I would agree with that choice (provided that we were to do this > change). > >> I've kept the wording from the original patch, which commits to a >> future change. We may instead relax this commitment and just say "the >> default is likely to change in a future version", or so. > > Please no. Keep it _very_ firmly committed. Otherwise we didn't > learn a thing from 1.6.3 era. The need for awareness building outside this mailing list remains, but the ball is in the court of "let's change the default" folks and I cannot do anything further on that front, so I'll focus on the patch itself in this message. The code seems quite competently done, except that the message text would want to live in a separate static array, if only to keep the lines in the patch not overly long. Also, The message taken from Jeff's $gmane/166787 may need to be tweaked further, waiting the conclusion of the discussion in the other subthread. Oh, another thing is that the "1.8.0" in Jeff's original was written back in 1.7.5 era. We would want to bump it to say "1.8" (or even "2.0"). Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html