Nguyễn Thái Ngọc Duy wrote: > --- a/parse-options.c > +++ b/parse-options.c > @@ -490,7 +490,7 @@ static int usage_argh(const struct option *opts, FILE *outfile) > s = literal ? "[%s]" : "[<%s>]"; > else > s = literal ? " %s" : " <%s>"; > - return fprintf(outfile, s, opts->argh ? opts->argh : "..."); > + return fprintf(outfile, s, opts->argh ? gettext(opts->argh) : "..."); It is ok to use _() with an argument that is not a string literal, and in fact it is needed if the argument is to be poisoned. Maybe it would be worth resending the patch to make the gettext() identifier not available in NO_GETTEXT builds, so this kind of thing is easier to catch. Thanks and hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html