Re: [PATCH 1/2] rebase -i: optimize the creation of the todo file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 8, 2012 at 12:20 PM, Johannes Sixt <j.sixt@xxxxxxxxxxxxx> wrote:
> Am 3/8/2012 11:42, schrieb Dominique Quatravaux:
>> +     shortsha1=$(echo $sha1 | cut -c1-7)
>
>> -             sha1=$(git rev-parse $shortsha1)
>
> Why do you call it "optimization" when you spend two or three subprocesses
> instead of one?

echo is a shell internal. "git rev-parse" is two processes just as
"cut" and a pipe. The difference is that cut doesn't hit the git
repository.

But the real purpose of this first change is to lay the ground for the
next one, so I'd be happy to change the patch description...


-- 
  Dominique Quatravaux
  +41 79 609 40 72
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]