Barry Wardell <barry.wardell@xxxxxxxxx> wrote: > -my $git_dir_user_set = 1 if defined $ENV{GIT_DIR}; > -$ENV{GIT_DIR} ||= '.git'; <snip> > unless ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) { <snip> > + git_cmd_try { > + $ENV{GIT_DIR} = command_oneline([qw/rev-parse --git-dir/]); > + } "Unable to find .git directory\n"; > + > + chdir $toplevel or die "Unable to chdir to '$toplevel'\n"; > $_repository = Git->repository(Repository => $ENV{GIT_DIR}); > } It looks like some places in "git svn (init|clone|multi-init)" rely on GIT_DIR being set. I noticed the first test of t9100-git-svn-basic.sh failing (causing everything else in that test to fail) with your patch. Can you fix those use cases (and ensure tests pass)? Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html