On Mon, Mar 05, 2012 at 02:04:37PM +0100, Thomas Rast wrote: > René Haber <rene@xxxxxxx> writes: > > > sh -c ' > > . /sw/lib/git-core/git-sh-setup > > get_author_ident_from_commit 16b94413cbce12531e8f946286851598449d3913 > > ' > > GIT_AUTHOR_NAME='Ren'é Haber > > GIT_AUTHOR_EMAIL='rene@xxxxxxx' > > GIT_AUTHOR_DATE='@1329212923 +0100' > [...] > That is, the garbage (if you try to read it as UTF-8) in the printf > string was matched and replaced byte-by-byte with 'x'. However, > Will was getting the unreplaced results > > 0000000: f89d 849e 0a ..... > > I'm not sure he has followed up on that problem; the only hope may be to > get a better 'sed'. Long ago, 47c9739e replaced the shell quoting in git-am with "git rev-parse --sq-quote" (instead of sed). Maybe we can do the same for get_author_ident_from_commit (though it is a little trickier there, as we are also parsing values directly out of --pretty=raw). It would be nice if the --pretty format placeholders had a "shell-quote" modifier, and we could just do: git show --format='GIT_AUTHOR_NAME=%(an:shell)' or something similar. for-each-ref knows about shell-quoting, but we can't use it here, because we are looking at arbitrary commits, not just ones pointed to by refs. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html