Re: [PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> The git_project_search_form() subroutine, introduced in a1e1b2d
> (gitweb: improve usability of projects search form, 2012-01-31) didn't
> get its arguments from caller correctly.  Gitweb worked correctly
> thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8
> fix for project search not working.
>
> Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx>
> ---
> Brown paper bug (a1e1b2d is in master).  I am extremly sorry about that.

Heh, mistakes happen.  Thanks for taking care of this.

>
>  gitweb/gitweb.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7398be1..e2e6a73 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5263,7 +5263,7 @@ sub git_patchset_body {
>  # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
>  
>  sub git_project_search_form {
> -	my ($searchtext, $search_use_regexp);
> +	my ($searchtext, $search_use_regexp) = @_;
>  
>  	my $limit = '';
>  	if ($project_filter) {
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]