On Tue, Feb 28, 2012 at 04:20:31PM -0800, Junio C Hamano wrote: > "git log -S<string>" is a useful way to find the last commit in the > codebase that touched the <string>. As it was designed to be used by a > porcelain script to dig the history starting from a block of text that > appear in the starting commit, it never had to look for anything but an > exact match. > > When used by an end user who wants to look for the last commit that > removed a string (e.g. name of a variable) that he vaguely remembers, > however, it is useful to support case insensitive match. > > When given the "--regexp-ignore-case" (or "-i") option, which originally > was designed to affect case sensitivity of the search done in the commit > log part, e.g. "log --grep", the matches made with -S/-G pickaxe search is > done case insensitively now. I can't imagine anybody would want to have different case-sensitivity options for grepping the commit message versus pickaxe. But even if they do, and we later add options to control them individually, we would still want the short-and-sweet "-i" to cover the common case of setting both. So I think the approach is good. The patch itself looks fine to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html