Jeff King <peff@xxxxxxxx> writes: > You would also get NULL if the object exists but is not a commit. Maybe: > > die("object '%s' does not point to a commit", ...) > > would be better? It covers the wrong-type case, and is still technically > true when the object does not exist. For this particular message I like the above a lot better. The output from "git grep -e 'invalid object' -e 'bad object'" seems to show that the use of both are fairly evenly distributed. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html