Tim Henigan <tim.henigan@xxxxxxxxx> writes: > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > index a4ffe7c..3505a4b 100644 > --- a/Documentation/CodingGuidelines > +++ b/Documentation/CodingGuidelines > @@ -44,6 +44,10 @@ For shell scripts specifically (not exhaustive): > properly nests. It should have been the way Bourne spelled > it from day one, but unfortunately isn't. > > + - The use of 'which' is not allowed. The output of 'which' is not > + machine parseable and its exit code is not reliable across > + platforms. It is more helpful to say "If you want to do Z, use X, not Y because Y is broken for such and such reasons", rather than "Never use Y because Y is broken ...". In this case, Z is "find out if a command is available on user's $PATH", and X is "type", I think. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html