Michał Kiedrowicz <michal.kiedrowicz@xxxxxxxxx> writes: > @@ -893,4 +900,20 @@ test_expect_success 'mimic ack-grep --group' ' > test_cmp expected actual > ' > > +cat >expected <<EOF > +space: line with leading space1 > +space: line with leading space2 > +space: line with leading space3 > +EOF > + > +test_expect_success 'grep -E "^ "' ' > + git grep -E "^ " space >actual && > + test_cmp expected actual > +' > + > +test_expect_success "grep -P '^ '" ' > + git grep -P "^ " space >actual && > + test_cmp expected actual > +' This test does not pass for me as I do not usually build with pcre; shouldn't it be protected with some test prerequisite? Otherwise the patch looks good; thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html