Luc Pionchon <pionchon.luc@xxxxxxxxx> writes: > Add the '*' modifier, similar to the '+' modifier, > to add a line-feed after a non-empty placeholder. Hrm, I thought I designed the plus and minus fairly carefully so that nobody needs to add this later. Wouldn't it be sufficient to write Foo%n%-d that says "We usually have LF after Foo, and write %d after that, but we might not have anything interesting in %d at all, in which case we don't add that %n"? > +test_expect_success 'add LF after non-empty (1) (empty)' ' > + git show -s --pretty=format:"%*d%s%nfoo%n" HEAD^^ >actual && Shouldn't this be equivalent to "%n%-d%s%nfoo%n", which in turn is covered by one of the previous tests (del LF before empty)? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html