On Thu, Feb 23, 2012 at 10:42:21AM +0100, Thomas Rast wrote: > strbuf_getline() was not documented very clearly, though a reader > familiar with getline() would not have had any questions about it. > strbuf_getwholeline() was not documented at all. Thanks for improving the existing docs. One suggestion: > `strbuf_getline`:: > > - Read a line from a FILE* pointer. The second argument specifies the line > - terminator character, typically `'\n'`. > + Read a line from a FILE*. The second argument specifies the > + line terminator character, typically `'\n'`. Reading stops > + after the terminator or at EOF. The terminator is removed > + from the buffer before returning. Returns 0 unless there was > + nothing left before EOF, in which case it returns `EOF`. The get*line functions are unlike the rest of the strbuf API in that they overwrite, rather than append to, the strbuf argument. Maybe: s/from a FILE\*/&, overwriting the existing contents of the strbuf/ ? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html