Philip Jägenstedt <philip@xxxxxxxxxx> writes:
> The style used for incrementing and decrementing variables was fairly
> inconsistenty and was normalized to use x++, or ((x++)) in contexts
> where the former would otherwise be interpreted as a command. This is a
> bash-ism, but for obvious reasons this script is already bash-specific.
>
> Signed-off-by: Philip Jägenstedt <philip@xxxxxxxxxx>
I am not sure if the kind of changes seen in the following hunks are
necessary but I do not care too deeply about it. Assuming that the
change does not make the emulation by zsh unhappy, will apply.
Please stop me if somebody has issues with this rewrite.
Thanks.
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index c63a408..1903bc9 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -178,10 +178,8 @@ __git_ps1_show_upstream ()
> for commit in $commits
> do
> case "$commit" in
> - "<"*) let ++behind
> - ;;
> - *) let ++ahead
> - ;;
> + "<"*) ((behind++)) ;;
> + *) ((ahead++)) ;;
> esac
> done
> count="$behind $ahead"
> @@ -739,7 +737,7 @@ __git_complete_remote_or_refspec ()
> local cur_="$cur" cmd="${words[1]}"
> local i c=2 remote="" pfx="" lhs=1 no_complete_refspec=0
> if [ "$cmd" = "remote" ]; then
> - c=$((++c))
> + ((c++))
> fi
> while [ $c -lt $cword ]; do
> i="${words[c]}"
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html