Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> For a change that not just adds parameters but removes an existing one, >> this is way under-described with neither in-code comment nor log message. > > But it doesn't. src is renamed to ref. That is exactly why I mentioned that this is a "chance" in the part of my message you did not quote ;-). It was a chance for you to learn how the thought process of others may work or not work well, depending on how well the log message at the top prepares their mind before they start to read the patch, by looking at how one reader (me) tried to figure your patch out. Anything that I said in the message you are responding to that tempts you to say "No you are reading wrong" is an indication that the patch did not do a good job to help the reader understand what you wanted to do. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html