Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>> Perhaps "enum map_direction { SRC_TO_DST, DST_TO_SRC }" or something?
>
> I think only FROM_SRC, FROM_DST is more than enough to figure it out.
Yeah, as you can tell from my "or something", as long as the name makes
the direction clear, I don't care too much about the exact spelling.
>> Perhaps rename this to "map_push_refs()" or something in the patch 2/3?
>
> I think get_ref_match() would be more appropriate because we are
> acting on a specific (singular) ref, and the primary thing we care
> about is getting the peer name, based on the refspec match, which we
> might want as a return value.
Again, as long as the name makes it clear this is meant only for "push"
and never be used for "fetch", I am fine with it. One way to make it sure
is to have a substring "_push" somewhere in that name.
> Probably some rebase mistake =/
Thanks; I was wondering if there is something subtle unexplained going on.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html