Pete Wyckoff <pw@xxxxxxxx> writes: >> Improved-by: Pete Wyckoff <pw@xxxxxxxx> >> Signed-off-by: Luke Diamand <luke@xxxxxxxxxxx> > > Looks brilliant. Ack. Thanks for suffering through N rounds of > review. :) Well, I hate to say that I need to ask another round, to redo this patch on top of ld/git-p4-expanded-keywords topic that has already been in 'next'; a patch that replaces what is in 'next' will lose fix-ups for issues I pointed out in the first round that you forgot to follow and were fixed up locally by me when I queued the existing one. When working on an improvement to what you have sent out, please make it a habit of comparing your result with what are already queued, even when the earlier patches are still in 'pu'. They often are polished with trivial improvements (both to the patch and the log message) based on review comments from people when they are queued, which you do not want to lose. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html