Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > Return value NULL in this case means "no conversion needed", which is > not quite true when conv == -1. Doing this only when producing new commits to avoid spreading damage might be a good idea. But utf8.c::reencode_string() is sufficiently deep in the call-chains to make me suspect that the codepaths this change affects are not limited to creation ones. If this also forbids readers from resurrecting salvageable bits while reading (imagine your commit had "encodign vscii" but your log message was in English, except only your name had letters outside ASCII that I cannot locally convert to utf-8 for viewing), I do not think it is an acceptable change. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html