On Mon, Feb 20, 2012 at 3:34 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > John Szakmeister <john@xxxxxxxxxxxxxxx> writes: > >> This is my first time submitting a patch to git. I hope I've done >> things correctly! > > Looks good, except for the subject line that would have been better to say > something like: > > configure: don't use -lintl when there is no gettext support You're right, that's much better. I'll keep your feedback in mind for next time. > I'll tweak the log message and queue. Thanks Junio! -John -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html