Clemens Buchacher <drizzd@xxxxxx> writes: > diff --git a/t/t5523-push-upstream.sh b/t/t5523-push-upstream.sh > index 9ee52cf..3683df1 100755 > --- a/t/t5523-push-upstream.sh > +++ b/t/t5523-push-upstream.sh > @@ -101,10 +101,11 @@ test_expect_success TTY 'push -q suppresses progress' ' > ! grep "Writing objects" err > ' > > -test_expect_failure TTY 'push --no-progress suppresses progress' ' > +test_expect_success TTY 'push --no-progress suppresses progress' ' > ensure_fresh_upstream && > > test_terminal git push -u --no-progress upstream master >out 2>err && > + ! grep "Unpacking objects" err && > ! grep "Writing objects" err > ' Very nice to see an old expect-failure turned into expect-success. > diff --git a/transport.c b/transport.c > index cac0c06..6074ee9 100644 > --- a/transport.c > +++ b/transport.c > @@ -994,10 +994,14 @@ void transport_set_verbosity(struct transport *transport, int verbosity, > * when a rule is satisfied): > * > * 1. Report progress, if force_progress is 1 (ie. --progress). > + * 2. Don't report progress, if force_progress is 0 (ie. --no-progress). > * 2. Don't report progress, if verbosity < 0 (ie. -q/--quiet ). > * 3. Report progress if isatty(2) is 1. > **/ I'll turn this into an unnumbered bulletted list, while I tease it apart to remove textual dependency on the 'verify-refs' extension, which this fix shouldn't depend on and taken hostage to. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html