Steven Walter <stevenrwalter@xxxxxxxxx> wrote: > On Sun, Feb 12, 2012 at 2:03 AM, Eric Wong <normalperson@xxxxxxxx> wrote: > > Steven Walter <stevenrwalter@xxxxxxxxx> wrote: > >> Signed-off-by: Steven Walter <stevenrwalter@xxxxxxxxx> > > > > Thanks, shall I fixup 2/2 and assume you meant to Sign-off on that, too? > > Yes, thanks Ugh, I got a bunch of test failures on t9100-git-svn-basic.sh with your updated 1/2 and a trivially merged 2/2: not ok - 7 detect node change from file to directory #2 not ok - 12 new symlink is added to a file that was also just made executable not ok - 13 modify a symlink to become a file not ok - 14 commit with UTF-8 message: locale: en_US.UTF-8 not ok - 16 check imported tree checksums expected tree checksums 1/2 alone seems to pass all existing tests. I would very much appreciate new test cases that can show exactly what's fixed by your patches (esp given the only times I run/use git-svn is when reviewing patches). Thanks!. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html