Am 12.02.2012 um 18:22 schrieb Junio C Hamano: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> 2012/2/12 Torsten Bögershausen <tboegi@xxxxxx>: >>> Added a simple auto-detection and switch to NO_GETTEXT when >>> msgfmt could not be found on the system >> >> Oh look, a start at our very own autoconf replacement :) > > It is a bad idea for the Makefile to silently decide to flip NO_GETTEXT > when the system happens to be missing msgfmt without letting the user know > what is happening. Current behaviour to error out will at least give an > opportunity to stop and think if installing gettext suite on the system > makes sense before proceeding. > > Given that the Makefile only has this to say: > > # Define NO_GETTEXT if you don't want Git output to be translated. > # A translated Git requires GNU libintl or another gettext implementation, > # plus libintl-perl at runtime. > > expecting that "msgfmt: no such command" clicks "Ah, I do not have gettext > suite" for anybody who attempts to build (and fail) Git, it however is > also a bit unfair and unhelpful. > > Perhaps something like this is necessary and sufficient. > > # Define NO_GETTEXT if you don't want Git output to be translated or if > # you do not have gettext suite (e.g. "msgfmt" and "gettext" commands). > # A translated Git requires GNU libintl or another gettext implementation, > # plus libintl-perl at runtime. Thanks all! a) the problem was fixed by "sudo apt-get install gettext", which leads to b) The comment was very helpful ( As I didn't know which package to install) and the final question: c) Should I send a new patch ? /Torsten -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html