Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> writes: > Junio suggested that "a new file, term.c or something, be a lot more > suitable home for the function you will be reusing from diff and other > parts of the system". Nevertheless, I think that adding two files (.c > and .h) to hold one function isn't worth it. It can live in pager.c. > Terminal size is logically connected to paging after all. I do not have any objection to the above reasoning. Given that Nguyen's columns topic hasn't been merged to 'next' and I expect it will be re-rolled anyway, I would prefer a patch that does the move from help.c to pager.c that is based directly on v1.7.9, on top of which your work and the columns topic can both be built independently. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html