Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> writes: > git_version_string is declared in builtins.h, but lived in git.c. > > When diff.c starts to use functions from help.c, linking against > libgit.a will fail, unless git.o containing git_version_string is > linked too. Sorry, it is unclear what you mean by the above, nor why you need this change in the first place. The resulting diff.o will certainly linked to git.o as it does not have its own "main()" at all. And builtins.h is a perfect place to declare things that are for the use of built-in commands like implementations of diff family of commands, as they all are linked into git.o (namely the commands[] array in handle_internal_command()) to be usable. What am I missing from between the lines of your log message? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html