On Tue, Feb 07, 2012 at 10:40:14PM -0800, Junio C Hamano wrote: > What I was getting at is that we probably should officially declare that > returning 1 to signal success is perfectly acceptable (and it probably > should mean the caller who called the callback function as a sub callback > should return immediately, taking it as a signal that the key has already > been handled), as the primary purpose of this thread to discuss Peff's > patch is to write these rules down. > > Of course, all that relies on the audit of the git_config() machinery. I > think it is written to accept non-negative as success, and that is why I > said "I too think this should be acceptable" in the first place. I looked through it the other day when this came up, and I believe that is the case. There is another related rule that should be considered, though: should the return value from callbacks be propagated via git_config to its caller? It is the case already for config files that are read, but not for config options parsed from the command line. It would not be too hard to change, but I do not think any current callers care (as I mentioned earlier, these days with the "void *" data pointer, sane callers will simply pass in a pointer to a modifiable data area). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html